fix: do not suppress E409 from npm publish (#246)

Fixes #245

Author: mcous

dist/main.js

@@ -223,37 +223,34 @@ describe("compareAndPublish", () => {
     await expect(result).rejects.toThrow(errors.NpmCallError);
   });
 
-  it.each(["EPUBLISHCONFLICT", "E409"])(
-    "should allow an %s error from npm publish",
-    async (errorCode) => {
-      when(callNpmCli<"publish">)
-        .calledWith("publish", ["."], {
-          logger,
-          environment,
-          ignoreScripts: false,
-        })
-        .thenResolve({
-          successData: undefined,
-          errorCode,
-          error: new errors.NpmCallError("publish", 1, "oh no"),
-        });
-
-      const result = await subject.compareAndPublish(
-        manifest,
-        normalizedOptions,
-        environment
-      );
-
-      expect(result).toEqual({
-        id: undefined,
-        files: [],
-        oldVersion: "0.0.1",
-        type: undefined,
+  it("should allow an EPUBLISHCONFLICT error from npm publish", async () => {
+    when(callNpmCli<"publish">)
+      .calledWith("publish", ["."], {
+        logger,
+        environment,
+        ignoreScripts: false,
+      })
+      .thenResolve({
+        successData: undefined,
+        errorCode: "EPUBLISHCONFLICT",
+        error: new errors.NpmCallError("publish", 1, "oh no"),
       });
-    }
-  );
 
-  it("should raise a non-EPUBLISHCONFLIG from npm publish", async () => {
+    const result = await subject.compareAndPublish(
+      manifest,
+      normalizedOptions,
+      environment
+    );
+
+    expect(result).toEqual({
+      id: undefined,
+      files: [],
+      oldVersion: "0.0.1",
+      type: undefined,
+    });
+  });
+
+  it("should raise a non-EPUBLISHCONFLICT from npm publish", async () => {
     when(callNpmCli<"publish">)
       .calledWith("publish", ["."], {
         logger,

src/compare-and-publish/__tests__/compare-and-publish.test.ts

@@ -2,7 +2,6 @@ import type { NormalizedOptions } from "../normalize-options.js";
 import {
   callNpmCli,
   E404,
-  E409,
   EPUBLISHCONFLICT,
   type NpmCliEnvironment,
   PUBLISH,
@@ -67,11 +66,7 @@ export async function compareAndPublish(
       ? await callNpmCli(PUBLISH, publishArguments, cliOptions)
       : { successData: undefined, errorCode: undefined, error: undefined };
 
-  if (
-    publishCall.error &&
-    publishCall.errorCode !== EPUBLISHCONFLICT &&
-    publishCall.errorCode !== E409
-  ) {
+  if (publishCall.error && publishCall.errorCode !== EPUBLISHCONFLICT) {
     throw publishCall.error;
   }
 

src/compare-and-publish/compare-and-publish.ts

@@ -13,6 +13,7 @@ describe.concurrent("callNpmCli", () => {
         ignoreScripts: true,
         environment: {
           npm_config_scope: "@cool-scope",
+          npm_config_ignore_scripts: "false",
         },
       });
 
@@ -36,6 +37,7 @@ describe.concurrent("callNpmCli", () => {
         ignoreScripts: false,
         environment: {
           npm_config_scope: "@cool-scope",
+          npm_config_ignore_scripts: "false",
         },
       });