Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new SettingsIcon component and exports it from the icons index. A review comment suggests renaming the component from Settings to SettingsIcon to ensure consistency with the filename and to prevent naming collisions with the existing Settings export.
Signed-off-by: Prarthana <226818177+prarii@users.noreply.github.com>
dd7f380 to
50f5f43
Compare
| export const SettingsIcon: React.FC<SvgIconProps> = (props) => { | ||
| return ( | ||
| <SvgIcon {...props}> | ||
| <path d="M19.14 12.94c.04-.3.06-.61.06-.94 0-.32-.02-.64-.07-.94l2.03-1.58c.18-.14.23-.41.12-.61l-1.92-3.32c-.12-.22-.37-.29-.59-.22l-2.39.96c-.5-.38-1.03-.7-1.62-.94l-.36-2.54c-.04-.24-.24-.41-.48-.41h-3.84c-.24 0-.43.17-.47.41l-.36 2.54c-.59.24-1.13.57-1.62.94l-2.39-.96c-.22-.08-.47 0-.59.22L2.74 8.87c-.12.21-.08.47.12.61l2.03 1.58c-.05.3-.09.63-.09.94s.02.64.07.94l-2.03 1.58c-.18.14-.23.41-.12.61l1.92 3.32c.12.22.37.29.59.22l2.39-.96c.5.38 1.03.7 1.62.94l.36 2.54c.05.24.24.41.48.41h3.84c.24 0 .44-.17.47-.41l.36-2.54c.59-.24 1.13-.56 1.62-.94l2.39.96c.22.08.47 0 .59-.22l1.92-3.32c.12-.22.07-.47-.12-.61zM12 15.6c-1.98 0-3.6-1.62-3.6-3.6s1.62-3.6 3.6-3.6 3.6 1.62 3.6 3.6-1.62 3.6-3.6 3.6"/> |
There was a problem hiding this comment.
hi @prarii i have similar issue that i am working on, fairly new, but will u please lmk how to generate this path
There was a problem hiding this comment.
hey, click on the link mentioned in the issue; and then right click on the icon and click on inspect.
kishore08-07
left a comment
There was a problem hiding this comment.
@prarii
Take this https://github.com/layer5io/sistent/pull/1427/changes as reference template and refactor the changes accordingly.
Notes for Reviewers
This PR fixes #1419
Signed commits