Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ChevronRight icon component and its corresponding export index file. The review feedback suggests improving the component's implementation by utilizing the color prop from IconProps as a fallback for the SVG fill to ensure consistency with the interface, and adding a missing trailing newline to the source file.
Author
|
@kishore08-07 Hey can u review it once plz before merging |
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
ffe42e5 to
d389c0a
Compare
kishore08-07
suggested changes
Apr 22, 2026
| export const ChevronRight = ({ | ||
| width = DEFAULT_WIDTH, | ||
| height = DEFAULT_HEIGHT, | ||
| fill, |
Contributor
There was a problem hiding this comment.
fill = DEFAULT_FILL_NONE
Comment on lines
+1
to
+2
| import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants'; | ||
| import { ONYX_BLACK } from '../../theme'; |
Contributor
There was a problem hiding this comment.
import { DEFAULT_HEIGHT, DEFAULT_WIDTH, DEFAULT_FILL_NONE } from '../../constants/constants';
The meshmap package legitimately relies on peer-dep relaxation (e.g. jquery@^4 × cytoscape-clipboard), matching its own install:legacy-peer-deps script. Without this flag the bump job fails with ERESOLVE on npm install, matching the bump-layer5 job which already uses --legacy-peer-deps. Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
e13ccc4 to
0967b29
Compare
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: Utkarsh Anand <133217805+ITACHI161105@users.noreply.github.com> Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
Signed-off-by: ITACHI161105 <utkarsha137@gmail.com>
ITACHI161105
force-pushed
the
feat/add-chevron-right-icon
branch
from
9349c09 to
f42e419
Compare
ITACHI161105
commented
Apr 22, 2026
Author
ITACHI161105
left a comment
ITACHI161105
left a comment
There was a problem hiding this comment.
"Addressed all review comments — added DEFAULT_FILL_NONE to imports, removed ONYX_BLACK, and updated the default fill and JSX accordingly."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1415
Added ChevronRight icon following the same pattern as ChevronLeft icon.