sessions: restore terminal after editor maximize#311961
Merged
hawkticehurst merged 3 commits intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Sessions window editor maximize/restore flow so that maximizing the editor only hides the panel when the Terminal view is currently visible, and restoring the editor reopens the Terminal panel if (and only if) the maximize action hid it.
Changes:
- Update Maximize Editor to hide the panel only when the visible panel is the Terminal view, tracking that state for restoration.
- Update Restore Editor to reopen the panel only when it was hidden by the maximize flow.
- Add regression tests for the maximize/restore behavior and document the layout behavior in
LAYOUT.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts |
Adds regression coverage for maximize/restore interactions with the Terminal panel. |
src/vs/sessions/contrib/editor/browser/editor.contribution.ts |
Implements conditional panel hiding on maximize and conditional panel restoration on restore. |
src/vs/sessions/LAYOUT.md |
Documents the new maximize/restore behavior and records it in the layout changelog. |
hawkticehurst
force-pushed
the
agents/maximize-editor-hide-terminal
branch
from
27bc39c to
89ecdcd
Compare
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
roblourens
previously approved these changes
Apr 22, 2026
hawkticehurst
force-pushed
the
agents/maximize-editor-hide-terminal
branch
from
89ecdcd to
7438176
Compare
roblourens
previously approved these changes
Apr 22, 2026
Restore the terminal panel when the sessions maximize editor flow hid it, so maximize and restore behave symmetrically. Add regression coverage for the maximize and restore command behavior and update the sessions layout spec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dispose the per-test instantiation service in the editor contribution regression tests and assert the maximize call order described by the test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hawkticehurst
force-pushed
the
agents/maximize-editor-hide-terminal
branch
from
7438176 to
4d4f278
Compare
DonJayamanne
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2026-04-22.at.2.02.40.PM.mov
Notes